• Tsuyoshi Horo's avatar
    Move WebBundleNavigationInfo to FrameNavigationEntry · b7b033eb
    Tsuyoshi Horo authored
    There is a bug that navigation of OOPIF's remote iframe in Web Bundle
    file cause DCHECK failure. The root cause of the bug is that:
      - When NavigationControllerImpl::NavigateFromFrameProxy() is called
        for a remote iframe, this method clones the committed
        NavigationEntryImpl.
      - NavigationRequest's constructor clones the WebBundleNavigationInfo
        of the passed NavigationEntryImpl. This is not correct, because
        WebBundleNavigationInfo should be attached to the frame, not the
        page.
    
    To fix this bug, this CL moves WebBundleNavigationInfo from
    NavigationEntryImpl to FrameNavigationEntry.
    
    Bug: 1058721, 1040800
    Change-Id: Ia654876cfd08433550d1bdb9b81e0aac402fe61b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091191Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
    Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#748218}
    b7b033eb
navigation_controller_impl.cc 151 KB