GitLab

This CL only handles the difficult cases in //remoting. The easy cases
were tackled by mechanical CLs, such as https://crrev.com/c/1188959 for
//net. Parallel CLs will tackle other difficult cases.

net::IOBuffer is (thread-safe) ref-counted. Asides from improving the
ability to reason about instance ownership locally, creating instances
via base::MakeRefCounted makes it possible to use 1-based ref-counting
in the future (see base/memory/ref_counted.h).

This CL replaces raw IOBuffer pointers with scoped_refptr<net::IOBuffer>
in some APIs. Local inspection of the impacted implementations should
reveal that no extra reference churn was introduced.

Change-Id: I59940c49e6635540a4a42840919ff114b3a1941f
Reviewed-on: https://chromium-review.googlesource.com/1215463Reviewed-by: Gary Kacmarcik <garykac@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590076}