• Avery Musbach's avatar
    overview: Remove unnecessary check in OverviewSession::OnKeyEvent · b8363b4e
    Avery Musbach authored
    When you press the Escape key, OverviewSession::OnKeyEvent checks for
    split view mode with no overview windows, to avoid ending overview then.
    This check is unnecessary because OverviewController::ToggleOverview
    will bail out. It will hide the virtual keyboard first, but when you
    press the Escape key in the first place, you must have an external
    keyboard and therefore no virtual keyboard. FALLTHROUGH between case
    ui::VKEY_BROWSER_BACK and case ui::VKEY_ESCAPE is also unnecessary, and
    is inconsistent with between case ui::VKEY_RIGHT and case ui::VKEY_TAB.
    
    Test: ash_unittests OverviewSessionTest.ExitOverviewWithKey
    Change-Id: I26e5d6ae752d040aaf1bc40c798f00548c4730fd
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733727Reviewed-by: default avatarSammie Quon <sammiequon@chromium.org>
    Commit-Queue: Avery Musbach <amusbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#683681}
    b8363b4e
overview_session.cc 37.4 KB