• Bruce Dawson's avatar
    Fix UAF and reenable test · b8479b16
    Bruce Dawson authored
    RestrictedTokenTest.OpenLowPrivilegedProcess was occasionally failing
    under asan due to a use-after-free failure. Some of the output was
    misleading (in particular the line number of the claimed use-after-free)
    but the size/offset/alloc-size/alloc-site/free-site information was
    enough to find the bug and create a simple fix.
    
    The lesson is to not use a member of an object to identify the object to
    delete.
    
    Bug: 1012356
    Change-Id: Iac5e032c5f4bc364eb367a8424a18868918f6181
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427055Reviewed-by: default avatarJames Forshaw <forshaw@chromium.org>
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#810213}
    b8479b16
broker_services.cc 21.8 KB