• David 'Digit' Turner's avatar
    android: Add missing localized string outputs. · b86c8d52
    David 'Digit' Turner authored
    This CL adds Android resource strings xml files to various
    android_resources() targets, which didn't previously included
    them to avoid embedding them inside Chrome APKs (in order to
    save space).
    
    However, a previous CL [1] has changed the way resource strings
    are packaged by our build system, with better control of how
    these end up inside APKs and App Bundles. In a nutshell, these
    new strings will only be added to app bundles, while APKs will
    still be limited to our subset of 45 locales (out of 53) to
    reduce install size.
    
    Most of the changes here were performed automatically by
    simply running the following command:
    
      build/android/check_android_grit_strings.py \
        --scan-dir . \
        --fix-inplace
    
    Which was written to fix BUILD.gn and GRIT input files.
    
    Other changes include:
    
    - Adding the necessary lines to build/android/lint/supressions.xml
    
    - Changing the definition |ui_locales| in ui/android/BUILD.gn to
      include the new locales as well.
    
    I have manually verified the content of the newly generated
    packages using build/android/dump_apk_resource_strings.py, i.e.
    that:
    
    - The output of Chrome / ChromeModern is unchanged (both public
      and internal versions).
    
    - The output of SystemWebview and Monochrome includes new
      translations for existing WebView-related strings. This is
      responsible for an increase of about 26 kiB in size.
    
    - The output of Chrome / ChromeModern / Monochrome bundles
      include new strings for the 9 new locales.
    
    [1] https://chromium-review.googlesource.com/c/chromium/src/+/1448169
    
    
    BUG=882860
    R=agrieve@chromium.org, estevenson@chromium.org, benmason@chromium.org, yfriedman@chromium.org, boliu@chromium.org
    
    Change-Id: Id233e1974d0102f444c8194dcce2f21a9e923899
    Binary-Size: Increase is due to new translations for WebView strings.
    Reviewed-on: https://chromium-review.googlesource.com/c/1448170
    Commit-Queue: David Turner <digit@chromium.org>
    Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
    Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: default avatarKen Rockot <rockot@google.com>
    Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
    Reviewed-by: default avatarBo <boliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#629588}
    b86c8d52
BUILD.gn 20.1 KB