GitLab

Step 5 for bug 1125106. This is a rework from part of the mega-patch in
https://chromium-review.googlesource.com/c/chromium/src/+/2462248.

Navigating on an error page should always be done as cross-document in
order to attempt to reload the page. We should make this decision in
the browser process directly instead of round-tripping through the
renderer.

This builds on the work of rakina@ in https://crrev.com/c/2581659 that
did the same for history navigations. We use the same is_error_page()
bool and also prevent same-document navigations from being attempted
in non-history cases. The switch from same-document to cross-document
is moved to a location that is shared between both code paths.

A NOTREACHED() is added to the blink code that shows our navigation
tests that navigate on an empty 404 page do not round-trip through
the renderer anymore. This will become a CHECK() in the future as
the RestartAsCrossDocument paths are removed.

R=nasko@chromium.org, dcheng@chromium.org

Bug: 1125106, 1147759
Change-Id: I2afaccf3de7764699aa6bb04c530d09f66f292b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626783
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843681}