• Tim Schumann's avatar
    Revert "[Paint Preview] Add font access for Linux" · ba3ae098
    Tim Schumann authored
    This reverts commit 4951143a.
    
    Reason for revert: PaintPreviewCompositorCollectionBrowserTest.TestInitializationSuccess fails on linux-chromeos-google-rel
    
    CI: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel?limit=100
    Instance: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-google-rel/9587
    
    example logs:
    [ RUN      ] PaintPreviewCompositorCollectionBrowserTest.TestInitializationSuccess
    [1:1:1123/144534.806495:WARNING:hugepage_text.cc(182)] The ordering seems incorrect, fall back to small page
    [17651:17651:1123/144534.888293:WARNING:audio_manager_linux.cc(52)] Falling back to ALSA for audio output. PulseAudio is not available or could not be initialized.
    [17651:17651:1123/144534.982920:INFO:profile_network_context_service.cc(206)] Using built-in cert verifier.
    [17651:17651:1123/144534.988049:ERROR:proximity_auth_profile_pref_manager.cc(189)] Failed to find local state prefs for current user.
    [17651:17651:1123/144535.011423:INFO:profile_network_context_service.cc(206)] Using built-in cert verifier.
    [17651:17651:1123/144535.017906:INFO:profile_network_context_service.cc(206)] Using built-in cert verifier.
    [17651:17651:1123/144535.019873:INFO:remote_commands_service.cc(40)] Fetching remote commands.
    [17651:17651:1123/144535.019945:WARNING:remote_commands_service.cc(42)] Client is not registered.
    [17651:17651:1123/144535.019973:INFO:remote_commands_invalidator.cc(34)] Initialize RemoteCommandsInvalidator.
    [17651:17651:1123/144535.019993:INFO:remote_commands_invalidator.cc(59)] Starting RemoteCommandsInvalidator.
    [17651:17651:1123/144535.020014:INFO:remote_commands_invalidator.cc(130)] RemoteCommandsInvalidator ReloadPolicyData.
    [17651:17651:1123/144535.020034:INFO:remote_commands_invalidator.cc(172)] Unregister RemoteCommandsInvalidator.
    [17651:17651:1123/144535.022879:WARNING:wallpaper_controller_client.cc(370)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
    [17651:17651:1123/144535.064656:ERROR:account_manager_migrator.cc(248)] Could not find a refresh token for the Device Account.
    [17651:17733:1123/144535.158896:WARNING:google_brand_chromeos.cc(39)] Brand code file missing: /opt/oem/etc/BRAND_CODE
    ../../content/public/test/browser_test_base.cc:605: Failure
    Failed
    RunLoop::Run() timed out.
    Stack trace:
    #0 0x55f14751ff09 (/b/s/w/ir/out/Release/browser_tests+0x70a8f08)
    
    [17651:17651:1123/144605.264003:INFO:remote_commands_invalidator.cc(47)] Shutdown RemoteCommandsInvalidator.
    [17651:17651:1123/144605.264078:INFO:remote_commands_invalidator.cc(70)] Stopping RemoteCommandsInvalidator.
    [17651:17651:1123/144605.264095:INFO:remote_commands_invalidator.cc(172)] Unregister RemoteCommandsInvalidator.
    [17651:17651:1123/144605.271554:WARNING:pref_notifier_impl.cc(40)] Pref observer for native_printing.external_print_servers_whitelist found at shutdown.
    [17651:17651:1123/144605.307536:WARNING:pref_notifier_impl.cc(40)] Pref observer for media_router.cast_allow_all_ips found at shutdown.
    [17651:17651:1123/144605.307567:WARNING:pref_notifier_impl.cc(40)] Pref observer for EulaAccepted found at shutdown.
    [17651:17651:1123/144605.307579:WARNING:pref_notifier_impl.cc(40)] Pref observer for browser.relaunch_heads_up_period found at shutdown.
    [17651:17651:1123/144605.307587:WARNING:pref_notifier_impl.cc(40)] Pref observer for browser.relaunch_notification_period found at shutdown.
    [17651:17651:1123/144605.307595:WARNING:pref_notifier_impl.cc(40)] Pref observer for browser.relaunch_notification found at shutdown.
    [  FAILED  ] PaintPreviewCompositorCollectionBrowserTest.TestInitializationSuccess, where TypeParam =  and GetParam() =  (30599 ms)
    
    Original change's description:
    > [Paint Preview] Add font access for Linux
    > 
    > Testing on Cluster Telemetry with Linux found an issue where SkFontMgr
    > wasn't initialized properly resulting in inability to start the
    > compositor. This is due to the lack of font access since we didn't
    > call EnsureBlinkInitializedWithSandbox. However, the compositor only
    > needs a fraction of the features that come with that call. This CL
    > starts the font_service which enables the SkFontMgr to initialize. Note
    > that we don't require WebSandboxSupport to be initialized (at least for
    > Linux) as all the fonts are stored in the provided SkPictures.
    > 
    > Test coverage for this will be added as part of the end-to-end tests
    > for the player. That should catch any issues with other platforms.
    > 
    > Bug: 1023377
    > Change-Id: I95a224f6f3759b1b8f8df2989222757ebbd4f12e
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908062
    > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
    > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    > Reviewed-by: Dominik Röttsches <drott@chromium.org>
    > Reviewed-by: Ian Vollick <vollick@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#718149}
    
    TBR=vollick@chromium.org,drott@chromium.org,jochen@chromium.org,ckitagawa@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1023377
    Change-Id: I0de7093d6612f2836ff8bfce30db5758d06da258
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932797Reviewed-by: default avatarTim Schumann <tschumann@chromium.org>
    Commit-Queue: Tim Schumann <tschumann@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#718460}
    ba3ae098
BUILD.gn 336 KB