• Chris Mumford's avatar
    Revert file://.../*.svgz files w/network service change. · ba9a4288
    Chris Mumford authored
    Revert two CL's that added support for loading *.svgz resources
    via the file scheme in the network service due to increased
    memory use.
    
    Original change's description:
    > Chrome supports loading gzipped SVG files from the file scheme
    > which was unsupported with the network service implementation.
    >
    > Note: The non-network service implementation of *.svgz loading
    > is currently broken on Linux, but works on Windows and macOS.
    > This change works on both platforms.
    >
    > Bug: 857117
    > Change-Id: Id90deba4761ea67d4ac7bef681051ea9326e113b
    > Reviewed-on: https://chromium-review.googlesource.com/c/1268960
    > Commit-Queue: Chris Mumford <cmumford@chromium.org>
    > Reviewed-by: Matt Menke <mmenke@chromium.org>
    > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#605136}
    
    Also reverted a second CL containing a speculative fix:
    > Fix memory performance regression in file:///*.svgz filter.
    >
    > A speculative fix for a 7%-19.2% regression of memory use. This
    > change releases the ZLib buffers used for Gzip inflation - releasing
    > the memory as soon as it is no longer needed instead of waiting for
    > the URLResponseBodyConsumer instance to be deleted.
    >
    > This change also fixes an incorrect reset of |zlib_wrapper_|, which
    > was calling release() instead of reset(), when zlib would fail to
    > initialize. This was likely a latent bug and not the cause of
    > the regression.
    >
    > Bug: 901891
    > Change-Id: I52687f5614b7a76c52f4b9d5317deb33a299e4cb
    > Reviewed-on: https://chromium-review.googlesource.com/c/1317922
    > Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
    > Commit-Queue: Chris Mumford <cmumford@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#607124}
    
    TBRing mmenke@ - main reviewer of initial CL.
    
    Note: These two CL's reverted cleanly with no conflicts.
    
    TBR=mmenke@chromium.org
    
    Bug: 901891
    Change-Id: I700b994797c4c2ac10ffef74f5c449cb5dfc0da8
    Reviewed-on: https://chromium-review.googlesource.com/c/1331610Reviewed-by: default avatarChris Mumford <cmumford@chromium.org>
    Commit-Queue: Chris Mumford <cmumford@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607341}
    ba9a4288
url_response_body_consumer_unittest.cc 12.2 KB