• Balazs Engedy's avatar
    Reland "Don't have two copies of //device/fido." · bae82629
    Balazs Engedy authored
    This is a reland of e23bd4d7, now without
    `dllimport`-annotated classes with inline MOCK_METHODs.
    
    Original change's description:
    > Don't have two copies of //device/fido.
    >
    > Prior to this change, both libcontents.so and content_unittests would
    > each have a copy of //device/fido because the test_support code would
    > pull in a copy directly. This caused there two be two copies of
    > |U2fDiscovery::g_factory_func_| – one used by the test_support code and
    > one by the code that's used for actual processing. That obviously breaks
    > things.
    >
    > This CL makes //device/fido a `component` instead of a `source_set`,
    > which, however, necessitates adding COMPONENT_EXPORT annotations to all
    > exported classes/functions/constants.
    >
    > The CL also cleans up the components by:
    >  -- adding some missing #includes and DISALLOW_COPY_AND_ASSIGNs, and
    >  -- moving dependencies included in public headers into `public_deps`.
    >
    > Bug: 785955, 820441
    > Change-Id: I7a2ab0977a3090ff91fcd8bb53b16d13419d434a
    > Reviewed-on: https://chromium-review.googlesource.com/955698
    > Commit-Queue: Balazs Engedy <engedy@chromium.org>
    > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
    > Reviewed-by: Adam Langley <agl@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#542472}
    
    TBR=jdoerrie@chromium.org
    
    Bug: 785955, 820441
    Change-Id: I9ed13c7d1105f133c5f54cce7f0a4d74f1d57904
    Reviewed-on: https://chromium-review.googlesource.com/958863
    Commit-Queue: Balazs Engedy <engedy@chromium.org>
    Reviewed-by: default avatarBalazs Engedy <engedy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#542523}
    bae82629
u2f_discovery.h 3.74 KB