• Conley Owens's avatar
    Report was_cached in SubresourceLoadInfo · bb2025ae
    Conley Owens authored
    This change adds a boolean `was_cached` to the SubresourceLoadInfo
    struct. This lets consumers know whether or not the response was
    fetched from the network cache. Notably, this is important for
    recording page load metrics when the Network Service is enabled.
    
    This reverts commit 0b2b1a92.
    
    Issues in the previous commit are fixed by retaining the exists_in_cache
    field.
    
    In a many cases when NavigationURLLoaderDelegate::OnRequestFailed() is
    called, NavigationURLLoaderNetworkService::OnResponseStarted() has not
    been called. In these cases, we cannot rely on using a stored
    was_cached value, since it may not be properly updated.
    
    BUG=816684,822237
    
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
    Change-Id: I0beb72b825ae0a12122170cec2e4f4358dda58af
    Reviewed-on: https://chromium-review.googlesource.com/966792Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
    Reviewed-by: default avatarJay Civelli <jcivelli@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Commit-Queue: Conley Owens <cco3@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#545626}
    bb2025ae
resource_dispatcher.cc 22 KB