GitLab

If this size inversion happened in a flex layout with a flex rule that
causes drop-out below minimum size and the view reported a minimum size
larger than its preferred size it would never display.

This CL fixes both the general case and the specific inversion in
ExtensionsToolbarButton.

It was manifesting as the PWA window not having an extensions menu icon
icon in very specific cases.

I just want to say how DEEPLY FRUSTRATING this one was to track down :/

Will follow up by attempting to make code in flex_layout_types.cc a
DCHECK instead of set-to-min after branch (want to be safe now, will
actually try to find inversions later).

Bug: 1059677, 1057901
Change-Id: Icea2fd739260c91f7d390ec15b890257d9715ac3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097134
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#749227}