• Karandeep Bhatia's avatar
    DNR: Resolve cyclic dependency with extensions/browser:browser_sources · bc0d3714
    Karandeep Bhatia authored
    extensions/browser/api/declarative_net_request:declarative_net_request
    depends on extensions/browser:browser_sources. However some sources in
    extensions/browser:browser_sources also depend on
    extensions/browser/api/declarative_net_request:declarative_net_request
    causing a cyclic dependency. This dependency is necessary since DNR
    needs to hook into the installation flow. This dependency is not
    declared which can cause problems (e.g. configs won't be propagated
    correctly).
    
    Fix this by creating a new leaf target on which both
    extensions/browser/api/declarative_net_request:declarative_net_request
    and extensions/browser:browser_sources can depend on.
    
    BUG=1064163
    
    Change-Id: I536567bb1c3ca03117bd779fd205fb49b1af4849
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117450
    Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
    Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#753433}
    bc0d3714
BUILD.gn 26.6 KB