• Lukasz Anforowicz's avatar
    Remove WebAuthBrowserTest...Client::DoesSiteRequireDedicatedProcess. · bcb53c0c
    Lukasz Anforowicz authored
    Why remove DoesSiteRequireDedicatedProcess
    ==========================================
    
    This CL removes
    ShellContentBrowserClient::DoesSiteRequireDedicatedProcess.  We plan
    to remove 2 other overrides of this ContentBrowserClient method in
    other CLs.  We want to remove this ContentBrowserClient method
    altogether, because
    1) it is currently the only reason
       SiteInstanceImpl::DetermineProcessLockURL needs to take
       BrowserContext* as an argument (and therefore is problematic on
       threads other than UI thread)
    2) the method was initially introduced to support --isolate-extensions
       which has been obsolete since shipping --site-per-process in M67.
    
    
    Removal mechanics
    =================
    
    agl@ (original author of the test) suggested to simply remove
    WebAuthJavascriptClientBrowserTest.RegisterDuringUnload for now.
    
    
    Change-Id: I5aeb3b113de642ef96d7a9abc35d0e9c42c45f86
    Bug: 898281
    Reviewed-on: https://chromium-review.googlesource.com/c/1308256
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
    Reviewed-by: default avatarAdam Langley <agl@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#605102}
    bcb53c0c
webauth_browsertest.cc 40.7 KB