• Martin Kreichgauer's avatar
    device/fido: fix a crash in IsUVPAA if Touch ID is flag-enabled. · bcfda9cf
    Martin Kreichgauer authored
    In 9aa7c545
    AuthenticatorImpl::IsUserVerifyingPlatformAuthenticatorAvailable was
    changed to make Touch ID unavailable in Incognito and if the embedder
    does not provide a configuration for the Touch ID authenticator. The
    latter check dereferenced a nullptr in AuthenticatorImpl's
    request_delegate_.  request_delegate_ only gets initialized for the
    duration of a MakeCredential or GetAssertion request. It is
    uninitialized during IsUVPAA.
    
    This works around the issue by adding a
    IsWebAuthenticationTouchIdAuthenticatorSupported instance method to
    ContentBrowserClient, so that the feature support can be checked without
    requiring a request delegate instance.
    
    Bug: 869651
    Change-Id: Ib64a2278d63047d68876e224d44a9aab96f9cfea
    Reviewed-on: https://chromium-review.googlesource.com/1157605Reviewed-by: default avatarAlex Moshchuk <alexmos@chromium.org>
    Reviewed-by: default avatarKim Paulhamus <kpaulhamus@chromium.org>
    Commit-Queue: Martin Kreichgauer <martinkr@google.com>
    Cr-Commit-Position: refs/heads/master@{#580014}
    bcfda9cf
chrome_content_browser_client.h 25 KB