• Chris Lu's avatar
    [ios] Move presenting_ DCHECK to after presentation context checks · bd157bae
    Chris Lu authored
    It is no longer true that presenting_ will always be false when
    PresentOverlayForActiveRequest is called. This can occur if the
    current active request is dismissed by being removed from the queue
    and adds another overlay in its completion callback. Instead, the
    DCHECK can be moved after the OverlayPresentationContext checks,
    which should be enough to early return when an overlay is already
    being presented.
    
    Bug: 1114547
    Change-Id: I1756df163dfb10e96537449491d0cfc5295c4aed
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360376
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
    Reviewed-by: default avatarMike Dougherty <michaeldo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#799195}
    bd157bae
overlay_presenter_impl.mm 19.9 KB