• Carlos IL's avatar
    Revert "Fix elision for bidirectional URLs" · bd2526d9
    Carlos IL authored
    This reverts commit bdc3ad55.
    
    Reason for revert: Bidi handling caused bugs for non-bidi URLs, for the time being this will be reverted while those are fixed, and a CL disabling elision experiments for bidi URLs will be merged to 86.
    
    Original change's description:
    > Fix elision for bidirectional URLs
    > 
    > URLs where the TLD is separate from the host, which can happen for URLs
    > of the form http://LTR.RTL/RTL, were displayed with a blank spot when
    > elision was enabled. This CL changes this so the in between section,
    > which is not elided in this case, is also not colored transparent.
    > 
    > Bug: 1117631
    > Change-Id: I9bba2d2c0d494a4021b8c8edaacc87084e040964
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368458
    > Reviewed-by: Tommy Li <tommycli@chromium.org>
    > Reviewed-by: Emily Stark <estark@chromium.org>
    > Commit-Queue: Carlos IL <carlosil@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#801559}
    
    TBR=tommycli@chromium.org,estark@chromium.org,carlosil@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1117631
    Change-Id: Idc2ac1d682b1ec5ca1c5d8efc60dad70e0f203d2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387483Reviewed-by: default avatarCarlos IL <carlosil@chromium.org>
    Commit-Queue: Carlos IL <carlosil@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#803650}
    bd2526d9
omnibox_view_views.cc 113 KB