GitLab

This reverts commit 2621701f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 780382 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzI2MjE3MDFmMTc0YTFmMWVmMWMyOGE0N2QzZDY3OWE3YjMzZDA0NzMM

Sample Failed Build: https://ci.chromium.org/b/8877036858738311632

Sample Failed Step: compile

Original change's description:
> Reland "Adds icon loading service with sandbox for Windows."
> 
> This is a reland of c3de1340
> 
> Original change's description:
> > Adds icon loading service with sandbox for Windows.
> >
> > Adds a new |SandboxType::kIconReader| with token and integrity
> > levels that allow PrivateExtractIcon to do its thing. The service is
> > only used for PE files which, as a complex format, should not
> > be parsed in the browser. Other icons are found based only on a
> > file's extension. These are handled in the browser as this is both
> > faster and allows a tighter sandbox to be applied to the PE file
> > parsing. PrivateExtractIcon (a documented but discouraged Windows API)
> > is used instead of SHGetFileInfo as SHGetFileInfo requires COM
> > which considerably weakens sandboxing.
> >
> > Adds basic icon loading test for all platforms.
> >
> > A follow-on CL will add a fallback for PE files for which no embedded
> > icon is available.
> >
> > Testing: adds a unit test for groups, plus
> > manual testing on Windows 7 x86 and Windows 10 x64.
> >
> > Bug: 1032250
> > Change-Id: I6975e5612d8b6f35e3216a67fc98592a45895c1b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987273
> > Commit-Queue: Alex Gough <ajgo@chromium.org>
> > Reviewed-by: Robert Liao <robliao@chromium.org>
> > Reviewed-by: Will Harris <wfh@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#779502}
> 
> TBR=robliao@chromium.org
> 
> Bug: 1032250
> Change-Id: I7b5bd3c66ff7c6935939c1f21ef9c45384183522
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252842
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Will Harris <wfh@chromium.org>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Commit-Queue: Alex Gough <ajgo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#780382}


Change-Id: I367d0f5483f93f8ccb78f1e5d79a54dabfb6373a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1032250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254899
Cr-Commit-Position: refs/heads/master@{#780404}