GitLab

A recent bug surfaced the fact that old clients (prior to USS) don't
handle well the case where invalid tab specifics are received over the
sync protocol (namely, with an invalid tab ID).

In the particular case of orphaned foreign tabs, i.e. tabs that have
been overriden -same tab ID- by a different sync entity -different tab
node ID-, the situation is problematic. AFAIK, these entities would only
be submitted by a USS client when custom passphrase is enabled, leading
to crashes in all devices a user is syncing with.

Fortunately, the USS implementation is behind a feature toggle and has
never been enabled or experimented with.

Bug: 840876
Change-Id: I20c9272b735f0515f4bf8c0e9fd15ca31c2113a0
Reviewed-on: https://chromium-review.googlesource.com/1051234
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557168}