GitLab

This reverts commit 1ade577e.

Reason for revert: Fix missing sim_detect_page_test.m.js error.

sim_detect_page_test.m.js was not updated in
chrome/test/data/webui/BUILD.gn:254 to new name
setup_loading_page_test.m.js causing build to fail. Ok to reland
as all instances of sim_detect_page_test have been updated to new
name.

Original change's description:
> Revert "[CrOS Settings] Update sim-detect-page to be more generic"
>
> This reverts commit c0d403ae.
>
> Reason for revert: May be causing chromeos errors. Speculatively reverting based on error log:
>
> https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863577786188639024/+/steps/isolate_tests/0/stdout?format=raw
>
> > 0cf1ad3e42632633d1110de0b0a6e30ef2599740	boringssl_ssl_tests
> isolate: isolate /b/s/w/ir/cache/builder/src/out/Release/browser_tests.isolate: failed to process: stat /b/s/w/ir/cache/builder/src/out/Release/gen/chrome/test/data/webui/cr_components/chromeos/cellular_setup/sim_detect_page_test.m.js: no such file or directory
>
> So this error is caused by sim_detect_page_test.m.js.
>
> Original change's description:
> > [CrOS Settings] Update sim-detect-page to be more generic
> >
> > Rename sim-detect-page to setup-loading-page and update UI to be used
> > for both psim and esim flows.
> >
> > Bug: 1093185
> > Change-Id: Iaf8934a3423c1ce21d6115bc9ea28c9d972738b8
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535231
> > Commit-Queue: Gordon Seto <gordonseto@google.com>
> > Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#827473}
>
> TBR=khorimoto@chromium.org,azeemarshad@chromium.org,gordonseto@google.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1093185
> Change-Id: I48421a06df20aadd0913c1ee9bc3dc313f31097d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538858
> Reviewed-by: Minoru Chikamune <chikamune@chromium.org>
> Commit-Queue: Minoru Chikamune <chikamune@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827659}

TBR=khorimoto@chromium.org,azeemarshad@chromium.org,chikamune@chromium.org,gordonseto@google.com

# Not skipping CQ checks because this is a reland.

Bug: 1093185
Change-Id: Idf13c31d7e56b81b0e246f25d78404dfa21f16a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540923Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Gordon Seto <gordonseto@google.com>
Cr-Commit-Position: refs/heads/master@{#827903}