• ckitagawa's avatar
    Reland "[Paint Preview] Compositing Service" · bdf51f8a
    ckitagawa authored
    This is a reland of ba5c7d6f
    
    Reverted as PaintPreviewTest.TestInvalidProto broke on the
    Win7 Test dbg and Linux Test dbg waterfall bots.
    
    Fix: modify the test to avoid serializing an invalid proto
    and instead just serialize a string. The point of the test
    was to see that the invalid proto wouldn't deserialize
    and that state would be handled properly.
    
    Using TBR as lots of reviewers (some OOO) and there is
    minimal change from original CL aside from one test.
    
    Revert: 29b91f26
    
    Original change's description:
    > [Paint Preview] Compositing Service
    >
    > Adds a paint preview compositor service for compositing collections of
    > SkPictures representing frames into bitmaps. This is very similar
    > in principle to the PDF compositor service, but produces tileable
    > bitmaps rather than a PDF.
    >
    > A client to this service should start the compositing collection
    > portion of the service in a utility process. The client can then
    > create and delete dedicated compositor instances for each group of
    > SkPictures. Realistically only one compositor will be actively
    > communicating at a time. However, multiple compositors can be
    > "warm" (data is deserialized and in memory for fast switching).
    >
    > Bug: 1011430
    > Change-Id: I21cb594cd94982f8d4fc5800d9ae4d74b5d9973b
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842273
    > Reviewed-by: Jochen Eisinger <jochen@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: Colin Blundell <blundell@chromium.org>
    > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
    > Reviewed-by: Ian Vollick <vollick@chromium.org>
    > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
    > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#709946}
    
    TBR=kenrb@chromium.org,jochen@chromium.org,blundell@chromium.org
    
    Bug: 1011430
    Change-Id: Ieafd0d2e197feb8b1d1711e05dd4acc6f185655f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886986Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarIan Vollick <vollick@chromium.org>
    Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#710748}
    bdf51f8a
BUILD.gn 25 KB