• pkotwicz@chromium.org's avatar
    This CL fixes two bugs: · bf42472a
    pkotwicz@chromium.org authored
    1) Makes the favicons (tab, bookmarks) look the same in the browser UI as they do in the renderer). This fixes a regression (probably by one of my CLs) since https://codereview.chromium.org/6117006
    2) Make the favicons in the tab strip look the same after refreshing. The difference is due to the conversions PNG -> NSImage and PNG -> SkBitmap -> NSImage producing visually different NSImages. In particular, the result is different when the input PNG data has no colorspace information specified. Cocoa defaults to the device colorspace when decoding PNG data with no colorspace information. The generic RGB colorspace is used for converting from SkBitmap to NSImage. 
    
    BUG=242877
    TEST=Manual, see bug
    
    Review URL: https://chromiumcodereview.appspot.com/16370006
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207990 0039d316-1c4b-4281-b951-d872f2087c98
    bf42472a
image_mac.mm 3.99 KB