• Eric Seckler's avatar
    netlog: Emit values of consistent type for params trace event arg · bf6cbdd2
    Eric Seckler authored
    Trace processor now merges args from begin/end event pairs with the
    same names, but it doesn't support merging if the value type of the arg
    changes between the two events.
    
    Netlog was previously emitting 'params: ""', i.e. setting the "params"
    arg to an empty string, if there were no params to be emitted. However,
    "params" is usually an JSON-object-type argument. Thus, the value types
    between empty and present arguments are inconsistent and cannot be
    merged successfully by trace processor.
    
    This patch changes netlog to output an empty object ('params: {}')
    when the argument is empty instead.
    
    Bug: 1048815
    Change-Id: Id20f66e78bd6f89f81cf6d456925cf7a01aa1d75
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050689
    Commit-Queue: Eric Seckler <eseckler@chromium.org>
    Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#740596}
    bf6cbdd2
trace_net_log_observer_unittest.cc 16.7 KB