• Jialiu Lin's avatar
    Avoid accessing PrefService from PasswordReuseDetector · bfa83bbb
    Jialiu Lin authored
    Previous implementation queries PrefService in
    PasswordReuseDetector::CheckNonGaiaEnterprisePasswordReuse(..). However,
    CheckNonGaiaEnterprisePasswordReuse(..) is called in a backgroud sequence,
    which violates the valid sequence check in PrefService. In other words,
    PrefService can NOT be called on background thread. Otherwise, it
    will causes crashing.
    This CL changes the implementation by propagating enterprise URLs to
    PasswordReuseDetector when PasswordStore is initialized to avoid accessing
    PrefService from PasswordReuseDetector.
    
    Bug: 852138
    Change-Id: I8556f259e6c0e4a7eee077e70db142739336ed67
    Reviewed-on: https://chromium-review.googlesource.com/1107247
    Commit-Queue: Jialiu Lin <jialiul@chromium.org>
    Reviewed-by: default avatarVasilii Sukhanov <vasilii@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#569358}
    bfa83bbb
safe_browsing_prefs.h 10.9 KB