• Elly Fong-Jones's avatar
    cbui: remove more GetDialogButtonLabel overrides · bfd343e9
    Elly Fong-Jones authored
    This change removes overrides from:
    * DesktopMediaPickerDialogView, which used static strings
    * DownloadDangerPromptViews, which used static strings conditional on a
      constructor parameter
    * HungRendererDialogView, which computes its strings but never updates them
      after creation
    * PermissionsBubbleDialogDelegateView, which used static strings conditional on
      GetDialogButtons(), which itself returned a constant
    * PasswordReuseModalWarningDialog, which used strings computed from a member
      that never changes after construction
    * TabModalConfirmDialogViews, which gets its strings from a delegate but never
      updates them
    * UninstallView, which used static strings
    
    This change also removes a couple of redundant overrides of GetDialogButtons
    that replicated the default, and const-ifies a couple of members where the
    const-ness helps reason about code correctness.
    
    Bug: 1011446
    Change-Id: I6f89e975895c16a492cc0becad98f43a4f96e6c9
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862119
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#706104}
    bfd343e9
uninstall_view.cc 7.27 KB