• Jeroen Dhollander's avatar
    Reland "Add Assistant integration tests using a fake S3 server." · bfeae890
    Jeroen Dhollander authored
    This is a reland of crrev.com/c/1894296
    
    The commit was reverted in crrev.com/c/1971041 because the new browser
    tests failed when run by the |linux-chromeos-chrome| trybot.
    
    The tests failed because the |fake_s3_server_main| binary was not copied
    over to the sandboxes used by the |linux-chromeos-chrome| trybot while
    it runs its tests.
    
    This is fixed by adding the |fake_s3_server_main| as a runtime dependency
    of the |browser_unittests| build target.
    
    Original change's description:
    > Add Assistant integration tests using a fake S3 server.
    >
    > These tests run as browser tests, use the real libassistant code and use a fake
    > s3 server to replay previously recorded conversations.
    >
    > This allows the Assistant to run CQ tests that verify the basic interactions
    > are not broken.
    >
    > More specifically, this uses a FakeS3Server library that was previously
    > created by the LibAssistant team. On the ChromeOS side I added hooks to
    > tell LibAssistant to use the FakeS3Server, and a test-fixture to start/stop
    > the fake S3 server during the browsertests.
    >
    > BUG: b/141264108
    > TESTS: in target |browser_tests| with names |AssistantBrowserTest.*|
    >
    > Change-Id: I89985c9e34eaa21a17eef69fa5b472fa39486d30
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894296
    > Reviewed-by: Sam McNally <sammc@chromium.org>
    > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
    > Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
    > Cr-Commit-Position: refs/heads/master@{#725214}
    
    TBR=xiyuan@chromium.org,sammc@chromium.org, xiaohuic@chromium.org
    TBRing reviewers:
       - Note There were no changes in any file since crrev.com/c/1894296 except |chrome/test/BUILD.gn|
       - xiyuan@ please look at assistant_test_api.h
       - sammc@ please look at assistant.mojom
       - xiaohuic@ please look at the assistant code
    
    Change-Id: I514daac006c1254db26adf8b0fd3f6be652f4581
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971225Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
    Cr-Commit-Position: refs/heads/master@{#725999}
    bfeae890
assistant_ash_test_base.cc 6.9 KB