• Chris Lu's avatar
    [ios] Remove delegate reset in OverlayPresenterImpl::OverlayWasDismissed · c036f14b
    Chris Lu authored
    OverlayPresenterImpl's |detached_presenting_request_queue_| is
    used to receive the OverlayRequestRemoved() delegate callback to
    extend the lifetime of the request being removed to
    OverlayPresenterImpl::OverlayWasDismissed in the instance
    of a presenting WebState being detached. However, this pointer
    does not guarantee the continued existence of the
    |detached_presenting_request_queue_|. In addition, in this callback,
    there is no need to reset the delegate since OverlayPresenterImpl
    doesn't need to listen for OverlayRequestRemoved() anymore with
    |presented_request_| being reset in this callback.
    
    Bug: 1155138
    Change-Id: Ie5ec9b3ee1fe85484ab51919e5f9656e3351f41b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575318Reviewed-by: default avatarMike Dougherty <michaeldo@chromium.org>
    Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#835313}
    c036f14b
overlay_presenter_impl.mm 20.2 KB