• Leonard Grey's avatar
    Mac: use last committed URL when enabling/disabling share menu · c0e0977a
    Leonard Grey authored
    Previously, we were using chrome::CanEmailPageLocation to check if share
    should be enabled, which checked against the current URL, but user the
    last committed URL to actually perform the share.
    
    I'm honestly not sure if the non-Mac email behavior is correct and
    would like to side-step that for a moment. On the Mac, we really want
    the committed URL since we pass along a screenshot to the share service.
    
    This changes adapts the logic of CanEmailPageLocation to the committed
    URL and inlines it in the share menu controller.
    
    Bug: 1095807
    Change-Id: Icad4f3766335d0156edf6d1078ea06b328cfed06
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261613Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Commit-Queue: Leonard Grey <lgrey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#781955}
    c0e0977a
share_menu_controller.mm 10.2 KB