• David Tseng's avatar
    Reland: Remove |mode| from ChromeVox · c0e53b73
    David Tseng authored
    Debug generates slightly different output than release.
    
    TBR=dtseng@chromium.org
    
    Original description:
    ChromeVox Classic is no longer available to users.
    This allows us to remove some complexity surrounding the idea of the various modes for ChromeVox (classic, next, etc).
    
    This change mostly is meant to be cleanup, but it also addresses some bugs. Namely, we unintentionally relied upon onModeChanged to trigger specific behaviors such as installing command handlers. This made sense when mode changes had to be supported. However, with this in a limbo state now that there is no classic mode, we can no longer invoke commands with an empty desktop.
    
    Original change:
    https://chromium-review.googlesource.com/c/chromium/src/+/825169
    
    Bug: 
    Change-Id: Ibcfe282ceacac766ca47edecaa3302d59be8fcd5
    Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
    Reviewed-on: https://chromium-review.googlesource.com/829976Reviewed-by: default avatarDavid Tseng <dtseng@chromium.org>
    Commit-Queue: David Tseng <dtseng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#524496}
    c0e53b73
background.js 17.6 KB