Reland: Remove |mode| from ChromeVox

Debug generates slightly different output than release.

TBR=dtseng@chromium.org

Original description:
ChromeVox Classic is no longer available to users.
This allows us to remove some complexity surrounding the idea of the various modes for ChromeVox (classic, next, etc).

This change mostly is meant to be cleanup, but it also addresses some bugs. Namely, we unintentionally relied upon onModeChanged to trigger specific behaviors such as installing command handlers. This made sense when mode changes had to be supported. However, with this in a limbo state now that there is no classic mode, we can no longer invoke commands with an empty desktop.

Original change:
https://chromium-review.googlesource.com/c/chromium/src/+/825169

Bug: 
Change-Id: Ibcfe282ceacac766ca47edecaa3302d59be8fcd5
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/829976Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524496}

chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

@@ -526,8 +526,6 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, MAYBE_ChromeVoxShiftSearch) {
     if (utterance == "Click me")
       break;
   }
-  speech_monitor_.GetNextUtterance();
-  EXPECT_EQ("Button", speech_monitor_.GetNextUtterance());
 
   // Press Search+/ to enter ChromeVox's "find in page".
   SendKeyPressWithSearch(ui::VKEY_OEM_2);

chrome/browser/resources/chromeos/chromevox/BUILD.gn

@@ -148,7 +148,6 @@ chromevox_modules = [
   "cvox2/background/panel_menu.js",
   "cvox2/background/panel_menu_item.js",
   "cvox2/background/recovery_strategy.js",
-  "cvox2/background/tabs_automation_handler.js",
   "cvox2/background/tree_walker.js",
   "cvox2/background/tutorial.js",
   "cvox2/injected/keyboard_handler.js",

chrome/browser/resources/chromeos/chromevox/chromevox/background/tabs_api_handler.js

@@ -9,7 +9,6 @@
 
 goog.provide('cvox.TabsApiHandler');
 
-goog.require('TabsAutomationHandler');
 goog.require('cvox.AbstractEarcons');
 goog.require('cvox.AbstractTts');
 goog.require('cvox.BrailleInterface');
@@ -73,9 +72,6 @@ cvox.TabsApiHandler.prototype = {
           cvox.NavBraille.fromText(this.msg_('chrome_tab_created')));
     }
     cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.OBJECT_OPEN);
-    if (tab) {
-      this.refreshAutomationHandler_(tab.id);
-    }
   },
 
   /**
@@ -115,7 +111,6 @@ cvox.TabsApiHandler.prototype = {
             this.msg_('chrome_tab_selected', [title])));
       }
       cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.OBJECT_SELECT);
-      this.refreshAutomationHandler_(tab.id);
     }.bind(this));
   },
 
@@ -161,7 +156,6 @@ cvox.TabsApiHandler.prototype = {
         cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.PAGE_FINISH_LOADING);
         this.cancelPageLoadTimer_();
       }
-      this.refreshAutomationHandler_(tabId);
     }.bind(this));
   },
 
@@ -193,29 +187,10 @@ cvox.TabsApiHandler.prototype = {
               cvox.NavBraille.fromText(this.msg_(msgId, [title])));
         }
         cvox.ChromeVox.earcons.playEarcon(cvox.Earcon.OBJECT_SELECT);
-        this.refreshAutomationHandler_(tab.id);
       }.bind(this));
     }.bind(this));
   },
 
-  /**
-   * Installs a new automation handler for the given tab.
-   * @param {number} tabId
-   * @private
-   */
-  refreshAutomationHandler_: function(tabId) {
-    if (!cvox.ChromeVox.isMac ||
-        ChromeVoxState.instance.mode == ChromeVoxMode.CLASSIC)
-      return;
-
-    chrome.automation.getTree(tabId, function(node) {
-      if (this.handler_)
-        this.handler_.removeAllListeners();
-
-      this.handler_ = new TabsAutomationHandler(node);
-    }.bind(this));
-  },
-
   /**
    * The chrome.tabs API doesn't always fire an onUpdated event when a
    * page finishes loading, so we poll it.

chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs

@@ -25,8 +25,6 @@ BackgroundTest.prototype = {
     window.RoleType = chrome.automation.RoleType;
     window.doCmd = this.doCmd;
 
-    // Reset notifications so only explicit mode changes can cause them to trigger.
-    Notifications.reset();
     this.forceContextualLastOutput();
   },
 
@@ -514,78 +512,6 @@ TEST_F('BackgroundTest', 'DISABLED_ActiveOrInactive', function() {
     });
 });
 
-TEST_F('BackgroundTest', 'ModeSwitching', function() {
-  this.runWithLoadedTree('<button></button>', function(root) {
-    var fakeDesktop = {};
-    fakeDesktop.role = 'desktop';
-    fakeDesktop.root = fakeDesktop;
-
-    var fakeWebRoot = {};
-    fakeWebRoot.root = fakeWebRoot;
-    fakeWebRoot.parent = fakeDesktop;
-    fakeWebRoot.role = RoleType.ROOT_WEB_AREA;
-    fakeWebRoot.makeVisible = function() {};
-    fakeWebRoot.unclippedLocation = {left: 1, top: 1, width: 1, height: 1};
-    var fakeSubRoot = {};
-    fakeSubRoot.root = fakeSubRoot;
-    fakeSubRoot.parent = fakeWebRoot;
-    fakeSubRoot.role = RoleType.ROOT_WEB_AREA;
-    fakeSubRoot.makeVisible = function() {};
-    fakeSubRoot.unclippedLocation = {left: 1, top: 1, width: 1, height: 1};
-    var bk = ChromeVoxState.instance;
-
-    // Tests default to force next mode.
-    assertEquals('force_next', bk.mode);
-
-    // Force next mode stays set regardless of where the range lands.
-    fakeWebRoot.docUrl = 'http://google.com';
-    bk.setCurrentRange(cursors.Range.fromNode(fakeWebRoot));
-    assertEquals('force_next', bk.mode);
-    // Empty urls occur before document load or when root is desktop.
-    fakeWebRoot.docUrl = '';
-    bk.setCurrentRange(cursors.Range.fromNode(fakeWebRoot));
-    assertEquals('force_next', bk.mode);
-
-    // Verify force next -> classic compat switching.
-    localStorage['useClassic'] = true;
-    fakeWebRoot.docUrl = 'chrome://foobar';
-    bk.setCurrentRange(cursors.Range.fromNode(fakeWebRoot));
-    assertEquals('classic_compat', bk.mode);
-
-    // Classic compat -> classic.
-    fakeWebRoot.docUrl = 'http://google.com';
-    bk.setCurrentRange(cursors.Range.fromNode(fakeWebRoot));
-    assertEquals('classic', bk.mode);
-
-    // Ensure we switch to classic compat if our current range has focused
-    // state set and is not in web content.
-    assertTrue(root.parent.state.focused);
-    bk.setCurrentRange(cursors.Range.fromNode(root.parent));
-    assertEquals('classic_compat', bk.mode);
-
-    // And back to classic.
-    bk.setCurrentRange(cursors.Range.fromNode(root));
-    assertEquals('classic', bk.mode);
-
-    // Now, verify mode switching uses the top level root.
-    fakeWebRoot.docUrl = 'http://google.com/#chromevox_next_test';
-    fakeSubRoot.docUrl = 'http://chromevox.com';
-    bk.setCurrentRange(cursors.Range.fromNode(fakeWebRoot));
-    assertEquals('next', bk.mode);
-
-    // Next compat switching.
-    localStorage['useClassic'] = false;
-    fakeWebRoot.docUrl = 'http://docs.google.com/document/#123123';
-    bk.setCurrentRange(cursors.Range.fromNode(fakeWebRoot));
-    assertEquals('force_next', bk.mode);
-
-    // And, back to force next.
-    fakeWebRoot.docUrl = 'http://docs.google.com/form/123';
-    bk.setCurrentRange(cursors.Range.fromNode(fakeWebRoot));
-    assertEquals('force_next', bk.mode);
-  }.bind(this));
-});
-
 TEST_F('BackgroundTest', 'ShouldNotFocusIframe', function() {
   this.runWithLoadedTree(  function() {/*!
     <iframe tabindex=0 src="data:text/html,<p>Inside</p>"></iframe>

chrome/browser/resources/chromeos/chromevox/cvox2/background/chromevox_state.js

@@ -8,24 +8,12 @@
  *     object and to facilitate mocking for tests.
  */
 
-goog.provide('ChromeVoxMode');
 goog.provide('ChromeVoxState');
 goog.provide('ChromeVoxStateObserver');
 
 goog.require('cursors.Cursor');
 goog.require('cursors.Range');
 
-/**
- * All possible modes ChromeVox can run.
- * @enum {string}
- */
-ChromeVoxMode = {
-  CLASSIC: 'classic',
-  CLASSIC_COMPAT: 'classic_compat',
-  NEXT: 'next',
-  FORCE_NEXT: 'force_next'
-};
-
 /**
  * An interface implemented by objects that want to observe ChromeVox state
  * changes.
@@ -67,19 +55,6 @@ ChromeVoxState.backgroundTts;
 ChromeVoxState.isReadingContinuously;
 
 ChromeVoxState.prototype = {
-  /** @type {ChromeVoxMode} */
-  get mode() {
-    return this.getMode();
-  },
-
-  /**
-   * @return {ChromeVoxMode} The current mode.
-   * @protected
-   */
-  getMode: function() {
-    return ChromeVoxMode.NEXT;
-  },
-
   /** @type {cursors.Range} */
   get currentRange() {
     return this.getCurrentRange();

chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

@@ -12,6 +12,7 @@ goog.require('ChromeVoxState');
 goog.require('CustomAutomationEvent');
 goog.require('Output');
 goog.require('cvox.ChromeVoxBackground');
+goog.require('cvox.ChromeVoxKbHandler');
 
 goog.scope(function() {
 var AutomationEvent = chrome.automation.AutomationEvent;
@@ -39,7 +40,7 @@ CommandHandler.onCommand = function(command) {
       ChromeVoxState.instance.setCurrentRange(null);
   });
 
-  // These commands don't require a current range and work in all modes.
+  // These commands don't require a current range.
   switch (command) {
     case 'speakTimeAndDate':
       chrome.automation.getDesktop(function(d) {
@@ -170,7 +171,6 @@ CommandHandler.onCommand = function(command) {
           'description=';
 
       var description = {};
-      description['Mode'] = ChromeVoxState.instance.mode;
       description['Version'] = chrome.app.getDetails().version;
       description['Reproduction Steps'] = '%0a1.%0a2.%0a3.';
       for (var key in description)
@@ -237,10 +237,6 @@ CommandHandler.onCommand = function(command) {
   if (!ChromeVoxState.instance.currentRange_)
     return true;
 
-  // Next/classic compat commands hereafter.
-  if (ChromeVoxState.instance.mode == ChromeVoxMode.CLASSIC)
-    return true;
-
   var current = ChromeVoxState.instance.currentRange_;
   var dir = Dir.FORWARD;
   var pred = null;
@@ -812,24 +808,6 @@ CommandHandler.onCommand = function(command) {
   return false;
 };
 
-/**
- * React to mode changes.
- * @param {ChromeVoxMode} newMode
- * @param {ChromeVoxMode?} oldMode
- */
-CommandHandler.onModeChanged = function(newMode, oldMode) {
-  // Previously uninitialized.
-  if (!oldMode)
-    cvox.ChromeVoxKbHandler.commandHandler = CommandHandler.onCommand;
-
-  var hasListener =
-      chrome.commands.onCommand.hasListener(CommandHandler.onCommand);
-  if (newMode == ChromeVoxMode.CLASSIC && hasListener)
-    chrome.commands.onCommand.removeListener(CommandHandler.onCommand);
-  else if (newMode == ChromeVoxMode.CLASSIC && !hasListener)
-    chrome.commands.onCommand.addListener(CommandHandler.onCommand);
-};
-
 /**
  * Increase or decrease a speech property and make an announcement.
  * @param {string} propertyName The name of the property to change.
@@ -927,9 +905,9 @@ CommandHandler.viewGraphicAsBraille_ = function(current) {
 
 /**
  * Performs global initialization.
- * @private
  */
-CommandHandler.init_ = function() {
+CommandHandler.init = function() {
+  cvox.ChromeVoxKbHandler.commandHandler = CommandHandler.onCommand;
   var firstRunId = 'jdgcneonijmofocbhmijhacgchbihela';
   chrome.runtime.onMessageExternal.addListener(function(
       request, sender, sendResponse) {
@@ -955,6 +933,4 @@ CommandHandler.init_ = function() {
   });
 };
 
-CommandHandler.init_();
-
 });  //  goog.scope

chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

@@ -81,9 +81,6 @@ DesktopAutomationHandler = function(node) {
   AutomationObjectConstructorInstaller.init(node, function() {
     chrome.automation.getFocus(
         (function(focus) {
-          if (ChromeVoxState.instance.mode != ChromeVoxMode.FORCE_NEXT)
-            return;
-
           if (focus) {
             var event =
                 new CustomAutomationEvent(EventType.FOCUS, focus, 'page');
@@ -137,9 +134,6 @@ DesktopAutomationHandler.prototype = {
 
     ChromeVoxState.instance.setCurrentRange(cursors.Range.fromNode(node));
 
-    if (!this.shouldOutput_(evt))
-      return;
-
     // Don't output if focused node hasn't changed.
     if (prevRange && evt.type == 'focus' &&
         ChromeVoxState.instance.currentRange.equals(prevRange))
@@ -162,9 +156,6 @@ DesktopAutomationHandler.prototype = {
    * @param {!AutomationEvent} evt
    */
   onEventIfInRange: function(evt) {
-    if (!this.shouldOutput_(evt))
-      return;
-
     var prev = ChromeVoxState.instance.currentRange;
     if (prev.contentEquals(cursors.Range.fromNode(evt.target)) ||
         evt.target.state.focused) {
@@ -245,9 +236,6 @@ DesktopAutomationHandler.prototype = {
    */
   onAlert: function(evt) {
     var node = evt.target;
-    if (!node || !this.shouldOutput_(evt))
-      return;
-
     var range = cursors.Range.fromNode(node);
 
     new Output().withSpeechAndBraille(range, null, evt.type).go();
@@ -279,9 +267,6 @@ DesktopAutomationHandler.prototype = {
    * @param {!AutomationEvent} evt
    */
   onChildrenChanged: function(evt) {
-    if (!this.shouldOutput_(evt))
-      return;
-
     var curRange = ChromeVoxState.instance.currentRange;
 
     // Always refresh the braille contents.
@@ -418,9 +403,6 @@ DesktopAutomationHandler.prototype = {
       return;
     }
 
-    if (!this.shouldOutput_(evt))
-      return;
-
     var t = evt.target;
     var fromDesktop = t.root.role == RoleType.DESKTOP;
     if (t.state.focused || fromDesktop ||
@@ -454,7 +436,7 @@ DesktopAutomationHandler.prototype = {
    */
   onScrollPositionChanged: function(evt) {
     var currentRange = ChromeVoxState.instance.currentRange;
-    if (currentRange && currentRange.isValid() && this.shouldOutput_(evt))
+    if (currentRange && currentRange.isValid())
       new Output().withLocation(currentRange, null, evt.type).go();
   },
 
@@ -558,19 +540,6 @@ DesktopAutomationHandler.prototype = {
     return !!this.textEditHandler_;
   },
 
-  /**
-   * Once an event handler updates ChromeVox's range based on |evt|
-   * which updates mode, returns whether |evt| should be outputted.
-   * @return {boolean}
-   */
-  shouldOutput_: function(evt) {
-    var mode = ChromeVoxState.instance.mode;
-    // Only output desktop rooted nodes or web nodes for next engine modes.
-    return evt.target.root.role == RoleType.DESKTOP ||
-        (mode == ChromeVoxMode.NEXT || mode == ChromeVoxMode.FORCE_NEXT ||
-         mode == ChromeVoxMode.CLASSIC_COMPAT);
-  },
-
   /**
    * @param {AutomationEvent} evt
    * @private
@@ -611,8 +580,6 @@ DesktopAutomationHandler.prototype = {
       }
 
       ChromeVoxState.instance.setCurrentRange(cursors.Range.fromNode(focus));
-      if (!this.shouldOutput_(evt))
-        return;
 
       Output.forceModeForNextSpeechUtterance(cvox.QueueMode.FLUSH);
       o.withRichSpeechAndBraille(

chrome/browser/resources/chromeos/chromevox/cvox2/background/find_handler.js

@@ -11,24 +11,10 @@ goog.require('Output');
 goog.scope(function() {
 var TreeChangeObserverFilter = chrome.automation.TreeChangeObserverFilter;
 
-/**
- * Responds to mode changes.
- * @param {ChromeVoxMode} newMode
- * @param {?ChromeVoxMode} oldMode Can be null at startup when no range was
- *  previously set.
- */
-FindHandler.onModeChanged = function(newMode, oldMode) {
-  if (newMode == ChromeVoxMode.FORCE_NEXT)
-    FindHandler.init_();
-  else
-    FindHandler.uninit_();
-};
-
 /**
  * Initializes this module.
- * @private
  */
-FindHandler.init_ = function() {
+FindHandler.init = function() {
   chrome.automation.addTreeChangeObserver(
       TreeChangeObserverFilter.TEXT_MARKER_CHANGES, FindHandler.onTextMatch_);
 };

chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js

@@ -12,9 +12,6 @@ goog.require('cvox.ChromeVoxKbHandler');
 
 /** @constructor */
 BackgroundKeyboardHandler = function() {
-  // Classic keymap.
-  cvox.ChromeVoxKbHandler.handlerKeyMap = cvox.KeyMap.fromDefaults();
-
   /** @type {number} @private */
   this.passThroughKeyUpCount_ = 0;
 
@@ -24,7 +21,9 @@ BackgroundKeyboardHandler = function() {
   document.addEventListener('keydown', this.onKeyDown.bind(this), false);
   document.addEventListener('keyup', this.onKeyUp.bind(this), false);
 
-  chrome.accessibilityPrivate.setKeyboardListener(true, false);
+  chrome.accessibilityPrivate.setKeyboardListener(
+      true, cvox.ChromeVox.isStickyPrefOn);
+  window['prefs'].switchToKeyMap('keymap_next');
 };
 
 BackgroundKeyboardHandler.prototype = {
@@ -38,8 +37,7 @@ BackgroundKeyboardHandler.prototype = {
     if (cvox.ChromeVox.passThroughMode)
       return false;
 
-    if (ChromeVoxState.instance.mode != ChromeVoxMode.CLASSIC &&
-        !cvox.ChromeVoxKbHandler.basicKeyDownActionsListener(evt)) {
+    if (cvox.ChromeVoxKbHandler.basicKeyDownActionsListener(evt)) {
       evt.preventDefault();
       evt.stopPropagation();
       this.eatenKeyDowns_.add(evt.keyCode);
@@ -72,32 +70,5 @@ BackgroundKeyboardHandler.prototype = {
     }
 
     return false;
-  },
-
-  /**
-   * React to mode changes.
-   * @param {ChromeVoxMode} newMode
-   * @param {ChromeVoxMode?} oldMode
-   */
-  onModeChanged: function(newMode, oldMode) {
-    if (newMode == ChromeVoxMode.CLASSIC) {
-      chrome.accessibilityPrivate.setKeyboardListener(false, false);
-    } else {
-      chrome.accessibilityPrivate.setKeyboardListener(
-          true, cvox.ChromeVox.isStickyPrefOn);
-    }
-
-    if (newMode === ChromeVoxMode.NEXT ||
-        newMode === ChromeVoxMode.FORCE_NEXT) {
-      // Switching out of classic, classic compat, or uninitialized
-      // (on startup).
-      window['prefs'].switchToKeyMap('keymap_next');
-    } else if (
-        oldMode && oldMode != ChromeVoxMode.CLASSIC &&
-        oldMode != ChromeVoxMode.CLASSIC_COMPAT) {
-      // Switching out of next. Intentionally do nothing when switching out of
-      // an uninitialized |oldMode|.
-      window['prefs'].switchToKeyMap('keymap_classic');
-    }
   }
 };

chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js

@@ -84,7 +84,7 @@ LiveRegions.prototype = {
     var mode = this.chromeVoxState_.mode;
     var currentRange = this.chromeVoxState_.currentRange;
 
-    if (mode === ChromeVoxMode.CLASSIC || !cvox.ChromeVox.isActive)
+    if (!cvox.ChromeVox.isActive)
       return;
 
     if (!currentRange)

chrome/browser/resources/chromeos/chromevox/cvox2/background/tabs_automation_handler.js

-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/**
- * @fileoverview Handles automation from a tabs automation node.
- */
-
-goog.provide('TabsAutomationHandler');
-
-goog.require('CustomAutomationEvent');
-goog.require('DesktopAutomationHandler');
-
-goog.scope(function() {
-var EventType = chrome.automation.EventType;
-var RoleType = chrome.automation.RoleType;
-var StateType = chrome.automation.StateType;
-
-/**
- * @param {!chrome.automation.AutomationNode} tabRoot
- * @constructor
- * @extends {DesktopAutomationHandler}
- */
-TabsAutomationHandler = function(tabRoot) {
-  DesktopAutomationHandler.call(this, tabRoot);
-
-  if (tabRoot.role != RoleType.ROOT_WEB_AREA)
-    throw new Error('Expected rootWebArea node but got ' + tabRoot.role);
-
-  // When the root is focused, simulate what happens on a load complete.
-  if (tabRoot.state[StateType.FOCUSED]) {
-    var event =
-        new CustomAutomationEvent(EventType.LOAD_COMPLETE, tabRoot, 'page');
-    this.onLoadComplete(event);
-  }
-};
-
-TabsAutomationHandler.prototype = {
-  __proto__: DesktopAutomationHandler.prototype,
-
-  /** @override */
-  didHandleEvent_: function(evt) {
-    evt.stopPropagation();
-  },
-
-  /** @override */
-  onLoadComplete: function(evt) {
-    var focused = evt.target.find({state: {focused: true}}) || evt.target;
-    var event =
-        new CustomAutomationEvent(EventType.FOCUS, focused, evt.eventFrom);
-    this.onFocus(event);
-  }
-};
-
-});  // goog.scope