Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
T
tangled
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • eriksson monteiro
  • tangled
  • Repository

Switch branch/tag
  • tangled
  • chrome
  • test
  • data
  • extensions
  • test_certificate_provider
  • extension.crx
Find file HistoryPermalink
  • Findit's avatar
    Revert "Reland Add browser tests for smart card SAML login" · c142dce8
    Findit authored Jan 28, 2020
    This reverts commit d5274dbb.
    
    Reason for revert:
    
    Findit (https://goo.gl/kROfz5) identified CL at revision 735947 as the
    culprit for flakes in the build cycles as shown on:
    https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDUyNzRkYmI0OGZlMDU2ZGRmNmFlMWNmZjQ2YjQ3OTVkNTU1NDFmOQw
    
    Sample Failed Build: https://ci.chromium.org/b/8889996165162517568
    
    Sample Failed Step: browser_tests
    
    Sample Flaky Test: SecurityTokenSamlTest.Basic
    
    Original change's description:
    > Reland Add browser tests for smart card SAML login
    > 
    > This relands the commit 8fd76b23 that
    > got reverted in commit 319c9b41 due to
    > failing on official trybots.
    > 
    > The fix in the reland is to suppress the sync consent screen that is
    > normally enabled on the "branded" builds and that was breaking test
    > expectations (the test expected the user session to start straight away
    > after the successful authentication without any extra screens).
    > 
    > Original change's description:
    > > Add browser tests for smart card SAML login
    > >
    > > Provide test coverage for the scenario where a new user authenticates
    > > via SAML using a smart card (or, generally speaking, using a security
    > > token via an extension using the chrome.certificateProvider API).
    > >
    > > This also provides some test coverage for the <security-token-pin>
    > > Polymer element used on the Login Screen.
    > >
    > > Bug: 1033936
    > > Change-Id: I5ded32e0570eb7227c77b954c33d12c1a8a62914
    > > Reviewed-on:
    > https://chromium-review.googlesource.com/c/chromium/src/+/1968989
    > > Reviewed-by: Alexander Alekseev <alemate@chromium.org>
    > > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
    > > Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
    > > Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#734510}
    > 
    > Bug: 1033936
    > Tbr: alemate@chromium.org, hendrich@chromium.org
    > Test: run the test locally with is_chrome_branded=true
    > Change-Id: I0e8394bb78030137c7570d58c2462a773c13ce06
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017430
    > Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
    > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#735947}
    
    
    Change-Id: Ifc621efff2f069cd90b25f9fff6d778a6732c2c3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1033936
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025885
    Cr-Commit-Position: refs/heads/master@{#736083}
    c142dce8
extension.crx 1.71 KB

Download (1.71 KB)

Replace extension.crx

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.