• Sunny Sachanandani's avatar
    Revert "Do not block shutdown for process launch on Windows" · c16fdebe
    Sunny Sachanandani authored
    This reverts commit 1a9c502d.
    
    Reason for revert: Speculative revert to fix headless_browsertests hangs https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/79454
    
    Original change's description:
    > Do not block shutdown for process launch on Windows
    > 
    > Launching a process is racy with browser shutdown, and blocks it. So we
    > see shutdown hangs when process launch takes a long time. This CL makes
    > the process launcher use a CONTINUE_ON_SHUTDOWN instead of
    > BLOCK_SHUTDOWN task on Windows where it's presumably safe to do so given
    > no non-leaky globals are used, and based on local testing. This is not
    > safe on Linux since the process launcher there uses SandboxHostLinux
    > which is a non-leaky base::Singleton.
    > 
    > R=​brucedawson,gab
    > BUG=830954
    > 
    > Change-Id: Ia8c5295924288819dcfdcc087d282a05e6ee7e55
    > Reviewed-on: https://chromium-review.googlesource.com/1020720
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    > Reviewed-by: Gabriel Charette <gab@chromium.org>
    > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#553294}
    
    TBR=gab@chromium.org,sunnyps@chromium.org,brucedawson@chromium.org,piman@chromium.org
    
    Change-Id: I4999a60d9f805fe441f416803dbb71fab8747f1b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 830954
    Reviewed-on: https://chromium-review.googlesource.com/1026437Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
    Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#553388}
    c16fdebe
child_process_launcher_helper.cc 8.18 KB