• Hans Wennborg's avatar
    Make WebSettings::V8CacheOptions an enum class, fixing -Wshadow warnings · c1a602ff
    Hans Wennborg authored
    A new version of Clang made the -Wshadow warning also apply to
    enumerators, warning that the blink::WebSettings::V8CacheOptions
    enumerators shadow the enumerators from blink::V8CacheOptions, e.g.
    
    49344/58815] CXX obj/third_party/blink/renderer/core/core_generated/v8_code_cache.o
    In file included from
    ../../third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc:9:
    ../../third_party/blink/public/web/web_settings.h:66:5: warning: declaration
    shadows a variable in namespace 'blink' [-Wshadow]
        kV8CacheOptionsDefault,
        ^
    ../../third_party/blink/renderer/bindings/core/v8/v8_cache_options.h:37:3:
    note: previous declaration is here
      kV8CacheOptionsDefault,  // Use whatever the current default is.
      ^
    
    Bug: 895475
    Change-Id: I6de82855f3db4655c1bfaa4bb8d77fab1466188e
    Reviewed-on: https://chromium-review.googlesource.com/c/1282445Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Reviewed-by: default avatarJochen Eisinger <jochen@chromium.org>
    Commit-Queue: Hans Wennborg <hans@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599974}
    c1a602ff
web_settings.h 15.2 KB