• Kurt Catti-Schmidt's avatar
    Fix crash in AXPlatformNodeBase::GetData · c26fb7e0
    Kurt Catti-Schmidt authored
    The crash for this bug is in ui::AXPlatformNodeBase::GetData, however
    the actual issue is that the node is nullptr due to it being out of
    range from the parent nodes children array. I traced this back to the
    parent's cached unignored child count being incorrect.
    
    This happens when node_id_to_clear is set - the node is cleared, but
    the parent's unignored cached values are not cleared. This change simply
    adds logic to add the parent node to the list of nodes to update
    their unignored cache. This logic is identical to what happens when
    the ignored state changes a few lines below.
    
    Bug: 974435
    Change-Id: I5392eff3cd31900739bff1f40a31edf7d84e9882
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769109
    Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
    Reviewed-by: default avatarAaron Leventhal <aleventhal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#690860}
    c26fb7e0
ax_tree.cc 83.2 KB