• Martin Kreichgauer's avatar
    win: don't show an error dialog after cancelling out of Win WebAuthn UI · c29eaf12
    Martin Kreichgauer authored
    This fixes a regression that caused cancelling out of the native Windows
    WebAuthn UI would show an error dialog, when the request should have
    just been ended right away.
    
    The error dialog in question contained a "retry" button, which was non-
    functional because it just returned the UI to an empty transport
    selection UI. Conceptually, we don't want to offer the "retry" button on
    Windows, because the Windows UI brings its own retry behavior for
    certain cases (e.g. user touched the wrong security key). Hence, this
    change also extends the retry logic on
    ChromeAuthenticatorRequestDelegate to hide retry buttons after
    dispatching a request to the Windows API.
    
    Bug: 985597
    Change-Id: Ie02721068c847156222e81f193fd446929ca996f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710741
    Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
    Reviewed-by: default avatarNina Satragno <nsatragno@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#680277}
    c29eaf12
authenticator_request_client_delegate.h 8.47 KB