-
Lalit Maganti authored
This CL adds the include_imports flag to protoc when generating descriptors. This flag is necessary to support any sort of imports in proto files as GN does not have support for transitively listing all the source files in a target and its deps. Since now include_imports silently looks at other source files other than the ones listed in the target, this means we need a depfile to allow ninja to pick up if changes are made in transitive dep source files. Unfortunately, protoc's depfile generation is broken out of the box and does not work with ninja. Add support in the wrapper script to correct this mirror what we do in Perfetto to achieve the same thing (see [1]) [1] https://cs.android.com/android/platform/superproject/+/master:external/perfetto/tools/protoc_helper.py Change-Id: Ib330520232280b3a8a9eb80a397fac2f3cd1e076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440887Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Lalit Maganti <lalitm@chromium.org> Cr-Commit-Position: refs/heads/master@{#813161}
c2a68d05