• James Cook's avatar
    chromeos: Migrate DriveFS off the mojo Identity Service · c2afb9b8
    James Cook authored
    The code in //chromeos/components/drivefs runs in the browser process
    on the UI thread. There aren't any plans to move it out of process.
    It can directly use the C++ IdentityManager instead of using the mojo
    Identity Service. This will eliminate the last client of the Identity
    Service, making it easier to refactor or delete it.
    
    Convert DriveFsAuth to use PrimaryAccountAccessTokenFetcher, which
    automatically handles waiting for / getting information about the
    primary account.
    
    Migrate the tests to use IdentityTestEnvironment, specifically the
    helpers for access token requests. This requires rewriting tests
    that used GMock on the Identity Service mojo API, but ends up being
    less code overall.
    
    Test: rewrite the chromeos_components_unittests
    Test: Google Drive still works in File Manager to read / write / copy
          files.
    Bug: 1054673
    
    Change-Id: If83be823ee2ab1936289e21b2c50451004557c17
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063419
    Commit-Queue: James Cook <jamescook@chromium.org>
    Reviewed-by: default avatarAustin Tankiang <austinct@chromium.org>
    Reviewed-by: default avatarColin Blundell <blundell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#744097}
    c2afb9b8
fake_drivefs.cc 15 KB