GitLab

* Remove duplicate includes.
* Include spdy_session.h for SpdySession::TimeFunc.
* s/NULL/nullptr/
* Ever since https://crrev.com/199633019 landed three and a half years
  ago, |expected_status| argument of CreateSpdySessionHelper() is
  unused.  Remove it, and remove the inaccurately named
  TryCreateSpdySessionExpectingFailure().
* Move |this_header| and |this_value| declaration closest to their first
  use in AppendToHeaderBlock().  The compiler should be smart enough to
  optimize this.
* In the same method use implicit pointer to bool conversion in DCHECKs.
* Purge naked news in favor of MakeRefCounted<> or make_unique<>.
* s/expected_error/expected_status/ for consistency.
* Use TestCompletionCallback::GetResult() [1] in
  CreateSpdySessionHelper() instead of inlining it.

[1] https://cs.chromium.org/chromium/src/net/base/test_completion_callback.h?l=72

Bug: 
Change-Id: Id5bc3f37f068f78901afbf8fb027cc6c63744b22
Reviewed-on: https://chromium-review.googlesource.com/775868
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517847}