• Xi Cheng's avatar
    Reland "Fix a few memory leaks in NotificationPlatformBridgeWin" · c2fbd138
    Xi Cheng authored
    This is a reland of 3d28a29b.
    
    In the original change, NotificationPlatformBridgeWinTest.Suppress and
    NotificationPlatformBridgeWinUITest.GetDisplayed failed in win-asan bot.
    
    This CL fixed it.
    
    The fix also required MockIToastNotification to derive from RuntimeClass,
    which significantly simplified its implementation.
    
    Original change's description:
    > Fix a few memory leaks in NotificationPlatformBridgeWin
    >
    > We should 1) wrap the bare pointers in ComPtr; and 2) attach
    > QueryInterfaces to ComPtr directly.
    >
    > Bug: 884224
    > Change-Id: I91cb5c7312d8e24f59962ffb33faadaba36bd7ef
    > Reviewed-on: https://chromium-review.googlesource.com/1227493
    > Commit-Queue: Xi Cheng <chengx@chromium.org>
    > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
    > Reviewed-by: Robert Liao <robliao@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#591737}
    
    Bug: 884224, 886957
    Change-Id: If2674299437f04f637f6b2b8278b40a4dbf7b9d0
    Reviewed-on: https://chromium-review.googlesource.com/1228991
    Commit-Queue: Xi Cheng <chengx@chromium.org>
    Reviewed-by: default avatarFinnur Thorarinsson <finnur@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#592487}
    c2fbd138
notification_platform_bridge_win.cc 35.9 KB