Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Submit feedback
  • Sign in / Register
T
tangled
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • eriksson monteiro
  • tangled
  • Repository

Switch branch/tag
  • tangled
  • chrome
  • test
  • data
  • extensions
  • theme
  • Cached Theme.pak
Find file HistoryPermalink
  • Rachel Carpenter's avatar
    Revert "Use common App Service profile checks for incognito redirect." · 16e1f095
    Rachel Carpenter authored Sep 01, 2020
    This reverts (part of) commit 6c131c38.
    
    Reason for revert: pak file got wrongly included
    
    Original change's description:
    > Use common App Service profile checks for incognito redirect.
    > 
    > https://crrev.com/c/2318888 added a "GetOriginalProfile" call to fix a
    > crash in incognito. Unfortunally that introduced a new crash for Guest
    > sessions. GetOriginalProfile() returns something that crashes when
    > trying to open a browser - see https://crbug.com/1121553. Add a new
    > method to AppService to handle the profile redirects correctly and in a
    > single place.
    > 
    > Also adds more tests.
    > 
    > Bug: 1122480
    > Change-Id: I63e3d2766d61b416d1e7590bc67a937b817848ed
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381230
    > Reviewed-by: Dominick Ng <dominickn@chromium.org>
    > Reviewed-by: Trent Apted <tapted@chromium.org>
    > Commit-Queue: Rachel Carpenter <carpenterr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#803399}
    
    TBR=tapted@chromium.org,dominickn@chromium.org,carpenterr@chromium.org
    
    Change-Id: If4f71581eddd4cffbd4a61ccef6bdee9f3c891f3
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1122480
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386909
    Commit-Queue: Rachel Carpenter <carpenterr@chromium.org>
    Reviewed-by: default avatarRachel Carpenter <carpenterr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#803410}
    16e1f095
Cached Theme.pak 98.5 KB

Download (98.5 KB)

Replace Cached Theme.pak

Attach a file by drag & drop or click to upload


Cancel
A new branch will be created in your fork and a new merge request will be started.