GitLab

This reverts commit bb25c608.

Reason for revert: WIP DO NOT LAND

Original change's description:
> Revert "[PartitionAlloc] Better freelist corruption detection."
>
> This reverts commit ac10443d.
>
> Reason for revert: Probably breaking mini_installer_tests and ProcessSnapshotTest.CrashpadInfoChild
> https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/112543
>
> Original change's description:
> > [PartitionAlloc] Better freelist corruption detection.
> >
> > Some PartitionAlloc crashes are likely due to freelist
> > corruption. PartitionAlloc has two types of freelists: in the central
> > allocator, and in the thread cache. The central allocator one already
> > has a DCHECK() to verify that subsequent entries belong the same
> > superpage, which doesn't hold for the thread cache freelists.
> >
> > This CL:
> > - Makes these crash lead to a NOINLINE function
> > - Add an interity check to all freelists.
> >
> > This is not meant to be a security mitigation, but to prevent against
> > accidental issues.
> >
> > Bug: 998048
> > Change-Id: I21aedfe2b6363069362514a8edd6cd5bdea1acfc
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582218
> > Commit-Queue: Benoit L <lizeb@chromium.org>
> > Reviewed-by: Chris Palmer <palmer@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#840587}
>
> TBR=palmer@chromium.org,haraken@chromium.org,lizeb@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
>
> Change-Id: Idd7f8213dae35146d4ada835cd443505f88749ce
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 998048
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612968
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#840622}

TBR=palmer@chromium.org,haraken@chromium.org,lizeb@chromium.org,mstensho@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

# Not skipping CQ checks because this is a reland.

Bug: 998048
Change-Id: I799d98335b5617d52a3eeb1e254d64f487144f87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613267Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846030}