• Greg Thompson's avatar
    Fix crashes in pipeline_integration_fuzzertest on GoogleTest assertion failure. · c3bbfd45
    Greg Thompson authored
    These tests use GoogleTest assertions without using GoogleTest's testing
    framework. Since UnitTest::Run() and friends (via RUN_ALL_TESTS) aren't
    used to run the tests, Google Test's stack trace getter's
    UponLeavingGTest method isn't called prior to running the actual test
    code. Upon assertion failure, there is no basis on which to trim the
    failure's stack trace.
    
    This CL adds a single call to UponLeavingGTest in LLVMFuzzerTestOneInput
    to provide such a basis. Better alternatives are to either run the tests
    via RUN_ALL_TESTS (after calling testing::InitGoogleTest) or not use
    GoogleTest assertions out of context.
    
    BUG=1039559
    
    Change-Id: I3aa5fa5a36361450548403babddb337af41d25d5
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089845Reviewed-by: default avatarXiaohan Wang <xhwang@chromium.org>
    Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
    Commit-Queue: Victor Costan <pwnall@chromium.org>
    Auto-Submit: Greg Thompson <grt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#747882}
    c3bbfd45
DEPS 254 Bytes