• Nico Weber's avatar
    Reland "Make AppMenuModel keep most submenus in a vector." · c3d4d98a
    Nico Weber authored
    This reverts commit dfd0e0a0.
    
    Reason for revert: This reverted half the change, leaving trunk broken,
    see https://crbug.com/1020524
    
    Original change's description:
    > Revert "Make AppMenuModel keep most submenus in a vector."
    > 
    > This reverts commit 849315dd.
    > 
    > Reason for revert: [sheriff] does not build on Mac per builder (https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf/125702)
    > 
    > Original change's description:
    > > Make AppMenuModel keep most submenus in a vector.
    > > 
    > > They are only needed for ownership, so no need to give them names and concrete
    > > types. Removes some forward declarations from the header and serendipitously
    > > happens to remove GOOGLE_CHROME_BUILD from the header as well.
    > > 
    > > No intended behavior change.
    > > 
    > > Bug: 961769
    > > Change-Id: Ibaaf3375bd9d367b4cc83b9a8ec3e64193750a69
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894032
    > > Commit-Queue: Robert Sesek <rsesek@chromium.org>
    > > Auto-Submit: Nico Weber <thakis@chromium.org>
    > > Reviewed-by: Robert Sesek <rsesek@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#711431}
    > 
    > TBR=thakis@chromium.org,rsesek@chromium.org
    > 
    > Change-Id: Id7abf98d32a424fdf3d8d0638c9967931eec30a8
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 961769
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893867
    > Reviewed-by: Armando Miraglia <armax@chromium.org>
    > Commit-Queue: Armando Miraglia <armax@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#711663}
    
    TBR=thakis@chromium.org,rsesek@chromium.org,armax@chromium.org
    
    Change-Id: Iae16e60dadcda2a91ff8207e214f18989caf5a53
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 961769
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895640Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#711703}
    c3d4d98a
app_menu_model.cc 33.1 KB