• Jon Mann's avatar
    Revert "tools/metrics/histograms/extract_histograms.py: Python 3 support" · c414efd0
    Jon Mann authored
    This reverts commit 465e6173.
    
    Reason for revert: Breaks build
    
    Original change's description:
    > tools/metrics/histograms/extract_histograms.py: Python 3 support
    >
    > Example error:
    > Traceback (most recent call last):
    >   File "../../tools/metrics/histograms/generate_expired_histograms_array.py", line 14, in <module>
    >     import extract_histograms
    >   File "C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py", line 60, in <module>
    >     import HTMLParser
    > ModuleNotFoundError: No module named 'HTMLParser'
    >
    > Also fixed deprecation warnings:
    > C:\Google\chromium\src\tools\metrics\histograms\extract_histograms.py:150: DeprecationWarning: The unescape method is deprecated and will be removed in 3.5, use html.unescape() instead.
    >   return HTMLParser().unescape(line)
    > ...C:\Google\chromium\src\tools\metrics\histograms\extract_histograms_test.py:481: DeprecationWarning: Please use assertEqual instead.
    >   self.assertEquals('This is a summary with & and " and \'',
    >
    > The changes are backwards compatible.
    >
    > Bug: 941669
    > Change-Id: Ieb22e72b37ec26886f3ca1341e487be4f0ba3ab1
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830657
    > Auto-Submit: Raul Tambre <raul@tambre.ee>
    > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
    > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#701265}
    
    TBR=asvitkine@chromium.org,raul@tambre.ee
    
    Change-Id: Ie6f8b307af54bd3d0ca347efef8908d013416879
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 941669
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830287
    Commit-Queue: Jon Mann <jonmann@chromium.org>
    Commit-Queue: Steven Holte <holte@chromium.org>
    Auto-Submit: Jon Mann <jonmann@chromium.org>
    Reviewed-by: default avatarSteven Holte <holte@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#701319}
    c414efd0
extract_histograms_test.py 17.7 KB