• jonross's avatar
    Have ActiveProfilePrefService Use the Original Profile · c4ba1060
    jonross authored
    ActiveProfilePrefService attempts to bind connections to the active profile.
    However Incognito profiles do not register with the preference service. This
    was leading to ServiceManagerConnectionImpl rejecting the connection, as there
    was no registered service.
    
    This change switches to using the original profile for the connection. Incognito
    profile is backed by a base ProfileImpl. All ProfileImpl properly register as a
    service.
    
    This change also reenables the ash::shell connection to the pref service.
    
    This change also reverts https://codereview.chromium.org/2795413002 which was
    landed to deal with possible race condition of request handlers. However this
    was not the root cause.
    
    TESTING=device actually boots now, ash::shell receives its connection to prefs.
    User can login.
    BUG=707321
    
    Review-Url: https://codereview.chromium.org/2802093005
    Cr-Commit-Position: refs/heads/master@{#462997}
    c4ba1060
service_manager_connection_impl.cc 19.9 KB