GitLab

ExtensionService::UninstallExtension takes a callback to call when the
data is removed for the extension's origin. Of the 60+ callers to this
method, the vast majority passed in base::Bind(&base::DoNothing), with
a handful more passing in an empty base::Closure. Only a single caller
(WebstoreReinstaller) passed in a "real" callback, and it appears to
be unnecessary. Additionally, the callback is already misleading - it
corresponds to removing storage partition data, but not chrome.storage
data.

This callback is also making a refactor on the cookies interface more
complicated, and may not be possible to maintain.

Remove the callback from the method interface.

Bug: 721395, 787563
TBR=benwells@chromium.org (c/b/apps)
TBR=atwilson@chromium.org (c/b/background, c/b/policy)
TBR=derat@chromium.org (c/b/chromeos)
TBR=treib@chromium.org (c/b/search)
TBR=estade@chromium.org (c/b/themes)
TBR=tapted@chromium.org (c/b/ui)

Change-Id: I1cbffd781fb90a40ff597e20ae80812b8646c5ef
Reviewed-on: https://chromium-review.googlesource.com/778040
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518402}