-
nancy authored
Launch service will be integrated to AppService, and removed, so this CL is used to migrate ExtensionAppLaunchManager::LaunchApplication to extensions application_launch. Based on the design go/integrating-launch-service-to-app-service, add BrowserAppLauncher class to AppService to handle the launch requests, and forward to extensions application_launch or WebAppLaunchManager. LaunchService->LaunchApplication is replaced with AppServiceProxy's new interface LaunchAppWithCallback. Follow up: 1. Get command line from the current process in GetLaunchFilesFromCommandLine: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/apps/app_service/launch_utils.cc;l=87 Remove command_line from interfaces parameters, and remove command_line from AppLaunchParams: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/apps/app_service/app_launch_params.h;l=57 2. Move ExtensionAppLaunchManager's OpenApplication function to AppService BrowserAppLauncher and remove ExtensionAppLaunchManager. 3. Modify web_app::WebAppLaunchManager to remove the dependency on LaunchManager. 4. Remove LaunchManager. Note: We can't name AppService's BrowserAppLauncher to LaunchService based on design now, because launch_service/launch_service hasn't been removed yet, and they are both in apps namespace, so rename it to BrowserAppLauncher. BUG=1061843 Change-Id: If5a36a9fe6b8ea265ed198d52fdddab477fe58a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119344Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753830}
804e4980