• Philip Rogers's avatar
    Revert "Promote PaintTouchActionRects to stable" · c5a7fbb9
    Philip Rogers authored
    This reverts commit 45013dfc.
    
    Reason for revert: Performance regressions on touch_handler_scrolling.html
    
    This patch turned up a few performance regressions, primarily:
    tough_scheduling_cases/touch_handler_scrolling.html
    (see: https://crbug.com/888269).
    
    Other performance regressions:
    https://chromeperf.appspot.com/group_report?rev=593255
    
    Original change's description:
    > Promote PaintTouchActionRects to stable
    >
    > This change enables PaintTouchActionRects by default. This is a
    > new implementation of how the blink->cc logic works for the css
    > touch-action feature. The big idea behind PaintTouchActionRects is to
    > compute touch-action rects during paint, in paint order, as part of the
    > background paint phase.
    >
    > With this change we expect better performance (primarily a drop in
    > ScrollingCoordinator time: Blink.ScrollingCoordinator.UpdateTime) as
    > well as observable bug fixes (e.g., https://crbug.com/826746).
    >
    > Bug: 836905, 881894
    > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    > Change-Id: I47a26250bad4c9e208b4f9b11e8eea3cf4d182aa
    > Reviewed-on: https://chromium-review.googlesource.com/1233114
    > Reviewed-by: Philip Rogers <pdr@chromium.org>
    > Commit-Queue: Xida Chen <xidachen@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#593255}
    
    TBR=pdr@chromium.org,xidachen@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 836905, 881894
    Change-Id: I775e60074f4d5bca5a907a1da104f5441212769a
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
    Reviewed-on: https://chromium-review.googlesource.com/1240184
    Commit-Queue: Philip Rogers <pdr@chromium.org>
    Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
    Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#593540}
    c5a7fbb9
compositor-touch-hit-rects-fullscreen-video-controls-expected.txt 339 Bytes