• Timothy Loh's avatar
    Revert "[ MimeHandlerView ] Block PluginStatus != kAllowed/kPlayImportantContent" · c6391e1a
    Timothy Loh authored
    This reverts commit 4ded38ed.
    
    Reason for revert: WebViewPluginTest.TestLoadPluginInternalResource timing out on linux-chromeos-dbg
    
    e.g. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/12542
    
    Original change's description:
    > [ MimeHandlerView ] Block PluginStatus != kAllowed/kPlayImportantContent
    > 
    > Currently, a MimeHandlerView is created as long as there is a plugin
    > for it. This behavior undermines issues such as <webview> permissions
    > API.
    > 
    > This CL will avoid creating MimeHandlerView if the plugin is not
    > allowed. This change will also make the test
    > WebViewPluginTest.TestLoadPluginInternalResource pass with the flag
    > MimeHandlerViewInCrossProcessFrame.
    > 
    > Note that when the plugin is not allowed, no (frame-based)
    > MimeHandlerView will be created and the code will follow the ordinary
    > CreatePlugin code path.
    > 
    > Bug: 963694
    > Change-Id: I91b88956480139ffdb0df06077d099746b713751
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622890
    > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
    > Reviewed-by: James MacLean <wjmaclean@chromium.org>
    > Reviewed-by: Tommy Li <tommycli@chromium.org>
    > Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
    > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#662641}
    
    TBR=thestig@chromium.org,tommycli@chromium.org,ekaramad@chromium.org,lukasza@chromium.org,wjmaclean@chromium.org
    
    Change-Id: I348e495fd03a3acaed1aaa86d71fee38770a9aa5
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 963694
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627837Reviewed-by: default avatarTimothy Loh <timloh@chromium.org>
    Commit-Queue: Timothy Loh <timloh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#662947}
    c6391e1a
web_view_browsertest.cc 175 KB