• Zinovy Nis's avatar
    [clang-tidy] Make DecodedDrawImage moveable to utilize std::move in ImageProvider. · c71ea170
    Zinovy Nis authored
    cc/paint/image_provider.cc:14:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg]
        : image_(std::move(image)) {}
                 ^~~~~~~~~~     ~
    cc/paint/image_provider.cc:18:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg]
        : image_(std::move(image)), destruction_callback_(std::move(callback)) {}
                 ^~~~~~~~~~     ~
    cc/paint/image_provider.cc:27:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg]
        : image_(std::move(other.image_)),
                 ^~~~~~~~~~            ~
    cc/paint/image_provider.cc:37:12: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg]
      image_ = std::move(other.image_);
               ^~~~~~~~~~            ~
    
    Change-Id: I2c3d49f7833ea117ef1b6aec4cf9037d19cb7c81
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489751Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
    Reviewed-by: default avatarvmpstr <vmpstr@chromium.org>
    Commit-Queue: Zinovy Nis <zynis@yandex-team.ru>
    Cr-Commit-Position: refs/heads/master@{#638479}
    c71ea170
decoded_draw_image.h 2.8 KB