• Leonard Grey's avatar
    Revert "Mac: modernize menu reveal tracking" · c72db149
    Leonard Grey authored
    This reverts commit 33253a15.
    
    Reason for revert: Broke PWA content fullscreen
    https://crbug.com/1109608
    
    Original change's description:
    > Mac: modernize menu reveal tracking
    > 
    > The fullscreen toolbar controller currently uses undocumented Carbon
    > events to track the menubar's reveal amount in fullscreen. In recent
    > macOS versions, the intermediate values are no longer send and we
    > only receive events when the menubar is fully shown or fully hidden.
    > 
    > The Mac immersive code which is still behind a flag uses a different
    > technique, observing the reveal amount on a hidden titlebar accessory
    > view. This *does* provide correct intermediate values.
    > 
    > This change extracts the reveal code from the immersive controller
    > and uses it in the current fullscreen code rather than the Carbon
    > event. Unfortunately, despite receiving the correct progress
    > notifications, the topchrome still does a discontinuous jump, but
    > we'll cross that bridge later.
    > 
    > Bug: 1063417
    > Change-Id: I6827cafbcad58eeaabf98c6facaeb85ce3439997
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314998
    > Reviewed-by: Avi Drissman <avi@chromium.org>
    > Commit-Queue: Leonard Grey <lgrey@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#791273}
    
    TBR=avi@chromium.org,lgrey@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1063417
    Change-Id: Ie70a1ce26feddaa6aec2e0f061b8dd7656fcf55e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320409Reviewed-by: default avatarLeonard Grey <lgrey@chromium.org>
    Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Commit-Queue: Leonard Grey <lgrey@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#791889}
    c72db149
BUILD.gn 205 KB